feat: allow skip cancel if named job in progress #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a democracy really, but I do want to register in this as well - this happens to me in one repo with one specific job and right now I'm just careful with what I run at the same time :-) |
|
Thanks for the PR! If this gets a few upvotes and others want it, we can merge it. I'll review soon 👍 |
|
This would be really great to have! |
ghost
deleted a comment
styfle
reviewed
Nov 21, 2021
| workflow_run_id: id, | ||
| jobs: jobs.filter( | ||
| ({ status, name }: any) => | ||
| status === 'in_progress' && disqualifying_jobs.includes(name), |
There was a problem hiding this comment.
Should we use Job ID instead of Job Name? Or at least make both work like we do for workflow name/id?
styfle
reviewed
Nov 21, 2021
| : [] | ||
| ).filter(workflow => workflow.jobs.length > 0); | ||
|
|
||
| let workflow_runs_to_cancel = [...workflow_runs]; |
|
This would be amazing to have, I was looking to implement exactly this. |
styfle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
I have a use case where if a named job is currently running the workflow should not be cancelled (deploying to S3). I figured I would create a PR in case anyone else sees value in the functionality.
Also open to any input, first PR for a github action.
Awesome work btw!